Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import error with ES6 js script embedded in html body #79

Open
benjaminpreiss opened this issue Apr 5, 2020 · 1 comment
Open

Import error with ES6 js script embedded in html body #79

benjaminpreiss opened this issue Apr 5, 2020 · 1 comment

Comments

@benjaminpreiss
Copy link

benjaminpreiss commented Apr 5, 2020 •
edited
Loading

  • Operating System: Windows 10 Pro
  • Node Version: 13.12.0
  • NPM Version: 6.14.4
  • webpack Version: 4.42.1
  • extract-loader Version: 5.0.1

Expected Behavior

extract-loader should correctly process ES6 files and their links passed to it by html-loader.

Actual Behavior

Running npx webpack resp. npm run webpack returns this error:

ERROR in ./src/html/index.html
Module build failed (from ./node_modules/extract-loader/lib/extractLoader.js):
C:\ ... \website\src\index.js:1
(function (exports, require, module, __filename, __dirname) { import { gsap } from 'gsap';
                                                              ^^^^^^

SyntaxError: Cannot use import statement outside a module
...

Code

webpack.config.js and package.json

index.html:

<!DOCTYPE html>
<html lang="en">
<head>
    ...
</head>
<body id="#body">
    <script type="module" src="../index.js"></script>
</body>
</html>

index.js:

import { gsap } from 'gsap';
import fullpage from 'fullpage.js';
import $ from 'jquery';

var ...

How Do We Reproduce?

File structure:

 - src/
         - html/
                - index.html
         - index.js

 - dist/
 - webpack.config.js
 - package.json

Then run npm run webpack
@cecilia-sanare cecilia-sanare mentioned this issue Jun 4, 2020
Closed
@cecilia-sanare
Copy link

Created a small example application that produces a similar error.

https://glitch.com/edit/#!/melted-bitter-music

lmmarsano added a commit to lmmarsano/extract-loader that referenced this issue Jun 15, 2020
@lmmarsano
add failing test cases for extracting scripts from html entry points
6205e48 
fails to extract scripts for html entry points
raises an exception when those scripts are ES modules
pertains to peerigon#79
@lmmarsano lmmarsano mentioned this issue Jun 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cecilia-sanare @benjaminpreiss