Export type for buttons components props #553
Conversation
🦋 Changeset detectedLatest commit: 36fedc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -201,122 +201,155 @@ type OnShippingAddressChangeActions = { | |||
|
|
|||
| export type DisplayOnlyOptions = "vaultable"; | |||
|
|
|||
| export type PayPalButtonCreateOrder = ( | |||
There was a problem hiding this comment.
This is totally my fault for putting this in the ticket, but wanted to throw this out there:
Do you think we should prefix these types with PayPalButtons___ instead of PayPalButton___ to match PayPalButtonsComponentOptions? 🤔
Open to either option 😄 But just thought I'd start the conversation.
There was a problem hiding this comment.
I think PayPalButton__ is better since we split them into a single button.
| @@ -201,122 +201,155 @@ type OnShippingAddressChangeActions = { | |||
|
|
|||
| export type DisplayOnlyOptions = "vaultable"; | |||
|
|
|||
| export type PayPalButtonCreateOrder = ( | |||
There was a problem hiding this comment.
Was there any discussion around why these types live in paypal-js instead of alongside the components they describe? I'm sure there's some history there, and it's not a blocker on this PR.
There was a problem hiding this comment.
I don't know about any discussion around this. Were you thinking of importing it from checkout-components?
Split up each prop in into its own type to export
// Old way
const styles: PayPalButtonsComponentOptions["styles"] = { ...your_button_styles }
// New way
const styles: PayPalButtonsStyles = { ...your_button_styles }