Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shape: sharp #551

Merged
merged 2 commits into from
Aug 7, 2024
Merged

add shape: sharp #551

merged 2 commits into from
Aug 7, 2024

Conversation

hnguyen510
Copy link
Contributor

Added shape: "sharp"

borderRadius: number was already added

Ticket: https://paypal.atlassian.net/browse/DTPPCPSDK-2114

@hnguyen510 hnguyen510 requested a review from a team as a code owner August 7, 2024 16:43
Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: d36e386

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@paypal/paypal-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@wsbrunson wsbrunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

with the removal of the commas though, I would do the following and see if that goes away

  • make sure you are running node 18
  • run npm install
  • run npm run format

and then see if there are any changes

Copy link
Contributor

@spencersablan spencersablan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 😄

@hnguyen510 hnguyen510 merged commit f96c7f6 into main Aug 7, 2024
3 checks passed
@hnguyen510 hnguyen510 deleted the Add-borderRadius-and-new-shape branch August 7, 2024 19:48
@hnguyen510
Copy link
Contributor Author

I will open a new pr to fix the formatting issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants