fix: message props update without button teardown #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where updating button message properties such as
amount
would tear down then rebuild the entire button component to render the new message. This fix allows just the message to rerender and preserves the button.Testing instructions:
Setup
paypal-js
PR locallynpm run build
in paypal-jspaypal-js
file explorer topackages/react-paypal-js/dist
and copy thecjs
andesm
directoriesnpm install
node_modules/@paypal/react-paypal-js/dist
cjs
andesm
directoriescjs
andesm
directories there.next
directory (previous node_module builds are cached there, and we do not want to use those)npm run dev
node: --openssl-legacy-provider is not allowed in NODE_OPTIONS
, you must first set the node version to the version specified in the.nvmrc
fileValidation