Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntonl / ntohs are function calls on Windows platorms #943

Open
pavel-odintsov opened this issue Jun 26, 2022 · 0 comments
Open

ntonl / ntohs are function calls on Windows platorms #943

pavel-odintsov opened this issue Jun 26, 2022 · 0 comments

Comments

@pavel-odintsov
Copy link
Owner

Hello!

Peter Dimov pointed me that ntohs / ntohl are function calls on Windows and it will serious performance penalty.

On Linux it's fine:
image

But Windows uses function call:
image

Details: https://godbolt.org/z/dE5rrbKzv

I think we need to switch to boost::endian::endian_reverse for Windows platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant