Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pg to v8 to avoid issue with Node 14 #218

Open
OliverJAsh opened this issue Mar 15, 2021 · 3 comments
Open

Upgrade pg to v8 to avoid issue with Node 14 #218

OliverJAsh opened this issue Mar 15, 2021 · 3 comments
Labels
bug help wanted 📁 Repo: with-postgres @build-tracker/plugin-with-postgres

Comments

@OliverJAsh
Copy link
Collaborator

Problem

When using Postgres + Node 14, queries never resolve.

Steps to Reproduce

  1. Use Postgres + Node 14
  2. Request /api/builds/1

Expected Result

A response

Actual Result

Request hangs forever

I believe this is because of brianc/node-postgres#2180. I suggest upgrading this dependency to v8.0.3 or above.
@paularmstrong paularmstrong added bug help wanted 📁 Repo: with-postgres @build-tracker/plugin-with-postgres labels May 14, 2021
@montogeek
Copy link

It does solve it.
@paularmstrong I can send a PR for that :)

@paulirish
Copy link
Contributor

@paularmstrong I can send a PR for that :)

@montogeek that'd be useful to me, at least. :) i just ran into this

paulirish added a commit to paulirish/lh-build-tracker that referenced this issue Aug 16, 2021
@paulirish
node 12 to avoid paularmstrong/build-tracker#218
32e19c0
@paulirish
Copy link
Contributor

btw this change will also need this.. at least to work on heroku. https://help.heroku.com/MDM23G46/why-am-i-getting-an-error-when-i-upgrade-to-pg-8

@paularmstrong paularmstrong mentioned this issue Sep 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted 📁 Repo: with-postgres @build-tracker/plugin-with-postgres
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paularmstrong @paulirish @OliverJAsh @montogeek