Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budgets silently fail when there is no "parent build" #122

Open
OliverJAsh opened this issue Feb 17, 2020 · 0 comments
Open

Budgets silently fail when there is no "parent build" #122

OliverJAsh opened this issue Feb 17, 2020 · 0 comments

Comments

@OliverJAsh
Copy link
Collaborator

Problem

When using budgets, if there is no parent build and the artifacts from the current build fail the defined budgets, comparator will not complain.

I suspect this is because of

return this.builds.slice(0, i).map(prevBuild => {

Most of the time this won't be an issue, as there will be a parent build, but it could confuse people (like me) who are just getting started with this tool.

I guess it doesn't make sense to run delta budgets when there is no parent build, but it does make sense to run standard size budgets?

Expected Result

Here's what I expect to see when I run the above:

Actual Result

Here's what I actually see when I run the above:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Low priority
Development

No branches or pull requests

1 participant