Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content header margin and component #349

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix content header margin and component #349

merged 1 commit into from
Sep 20, 2024

Conversation

fhlavac
Copy link
Collaborator

@fhlavac fhlavac commented Sep 18, 2024

RHCLOUD-35306

Fixed content header margin and component to <a> by default

Before:
image-2024-09-18-20-21-21-666

Now:
image

@fhlavac fhlavac changed the base branch from main to v5 September 18, 2024 20:21
@fhlavac fhlavac requested a review from dlabaj September 18, 2024 20:22
@fhlavac
Copy link
Collaborator Author

fhlavac commented Sep 18, 2024

/retest

@fhlavac
Copy link
Collaborator Author

fhlavac commented Sep 19, 2024

/retest

@fhlavac fhlavac closed this Sep 19, 2024
@fhlavac fhlavac reopened this Sep 19, 2024
@patternfly-build
Copy link

patternfly-build commented Sep 19, 2024 •
edited
Loading

Preview: https://react-component-groups-pr-component-groups-349.surge.sh

A11y report: https://react-component-groups-pr-component-groups-349-a11y.surge.sh

@fhlavac fhlavac merged commit 4455f30 into patternfly:v5 Sep 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlabaj dlabaj dlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhlavac @patternfly-build @dlabaj