Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in new solvers #435

Closed
lockwo opened this issue Jun 7, 2024 · 3 comments
Closed

Interest in new solvers #435

lockwo opened this issue Jun 7, 2024 · 3 comments
Labels
feature New feature

Comments

@lockwo
Copy link
Contributor

lockwo commented Jun 7, 2024

I have two classes of solvers I'm implementing with diffrax which I thought could be good to actually just put in diffrax, but I wanted to check if there was interest in having them in diffrax before I go through the process to get them ready for a PR.

First are some high weak order SDE solvers (Fixed step weak order 2.0 for Ito SDE solvers, e.g. SIEA etc. from https://docs.sciml.ai/DiffEqDocs/stable/solvers/sde_solve/)

Second are some diffusion model specific solvers (e.g. https://arxiv.org/abs/2105.14080). These come in two flavors: solvers that are applicable to general SDEs (or general SDEs of a certain type of noise) but perform well/better on diffusion models and solvers that are specific to (reverse) diffusion processes.

Would any subset of these be interesting to have in diffrax?

@lockwo lockwo changed the title Interest in solvers Interest in new solvers Jun 7, 2024
@patrick-kidger
Copy link
Owner

Definitely!

We'd need to think about how to correctly express solvers that are specific to certain diffusion processes, I suspect. Ideally these would throw an error if misused. (That's not crucial though.)

@patrick-kidger patrick-kidger added the feature New feature label Jun 7, 2024
@lockwo
Copy link
Contributor Author

lockwo commented Jun 10, 2024

Awesome, I think I have 3 open PRs right now 😅 , so that should give some time to get things into a presentable shape (and think on solver representation for specific diffusion processes)

@lockwo
Copy link
Contributor Author

lockwo commented Aug 9, 2024

Closing to open more specific issues as we work on getting these solvers in (e.g. #481)

@lockwo lockwo closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants