-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not including artwork #10
Comments
Can you share your code? How are you determining that it is not working? What is the output of |
Below my code ... a simple method call... then I just pass the mp3 file (I hardcoded the image name) Copying the file to Windows OS, OS X and running respective media players did not show the image.
|
Something is definitly not working. Here's my test using
Note that the @nucleardreamer any idea why this might not be working? |
So unfortunately, ffprobe will never be able to the embedded cover art, it's actually becomes part of the ID3 metadata! It's incredibly stupid, but mp3 metadata was never designed for binary images, and got kind of bolted on in ID3v2. Everything seems to be working fine for me running the tests, and using this module in a couple other projects I have. The most reliable way to test for the cover art is
and the same file size matches the test cover as well
Important note as well, because we are using ffmpeg it causes the album art to not have an official image type, only the default $00, from the frame translation, which equates to 'other' (ideally we would want to specify $03 front cover, and $04 back cover). I don't believe ffmpeg has options to set this :/ |
Well it seems to be working now... how? Easy Instead of building/using yum repo for ffmpeg I download ed the official static builds from FFMPEG after running the same exact set of commands passed by the nodejs module (or using cli) ffprobe was able to detect the image:
I guess I'll use this ffmpeg binary instead! |
Woa! I guess I've been living a lie! My ffmpeg was outputting the same as before. It does bother me that the metadata comment doesn't translate to the official ID3v2 schema. It's still catagorized as other which negates the option of classifying any other images correctly onto the same file. |
The problem is, the tag "comment: Cover (front)" isn't (correctly) set. Don't know how to fix it tho. When I put in a metadata extractor, the value of the field "comment" is "Other". |
Hi,
I've been using another library to tag my files until I discover yours... however even when I'm able to tag the data the artwork method is not working.
I tried png and jpg files nothing attach the files. I'm using ffmpet 0.10.x and libav 11.x in my server. When I call the method it says it was added so no error or exception is displayed something that I'm might be missing?
The text was updated successfully, but these errors were encountered: