Support TID #2970
Merged
Support TID #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
reviewed
Aug 14, 2024
reporter/parca_reporter.go
Outdated
| type labelsKey struct { | ||
| pid util.PID | ||
| tid util.PID | ||
| comm string |
There was a problem hiding this comment.
does comm really need to be a part of this key, isn't pid+tid already uniquely identifying the thread?
There was a problem hiding this comment.
yes, you're right.
However, we should still not cache comm, since it can change (e.g. if pthread_setname_np is called). But it doesn't need to be part of the key.
reporter/parca_reporter.go
Outdated
| lb.Set("comm", comm) | ||
| r.addMetadataForPID(pid, lb) | ||
| lb.Set("thread_name", key.comm) | ||
| lb.Set("tid", fmt.Sprint(key.tid)) |
There was a problem hiding this comment.
If we make these on by default as opposed to opt-in via relabeling, then we should probably also have the pid by default.
Also, can you add documentation about these here: https://github.com/parca-dev/parca-agent?tab=readme-ov-file#metadata-labels
brancz
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to our fork of opentelemetry-ebpf-profiler that supports thread IDs, and add the thread ID as a label.
Previously we were just getting the
commof the first thread we saw a sample for and saving that as the entire process'scomm. This PR saves that asthread_nameinstead and gets the main thread's comm (i.e. process name) from procfs, saving that ascomminstead.