Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define trait Transaction #11533

Open
Tracked by #7649
emhane opened this issue Oct 7, 2024 · 1 comment · May be fixed by #11877
Open
Tracked by #7649

Define trait Transaction #11533

emhane opened this issue Oct 7, 2024 · 1 comment · May be fixed by #11877
Assignees
@edisontim
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@emhane
Copy link
Member

emhane commented Oct 7, 2024

Describe the feature

Define trait reth_primitives_traits::Transaction. This trait should implement behaviour of reth_primitives::Transaction and have as supertrait alloy_consensus::Transaction, as well as any traits implemented on reth_primitives::Transaction e.g. From/TryFrom impls for reth_primitives::Transaction (and those From<reth_primitives::Transaction>/TryFrom<reth_primitives::Transaction> impls that translate to Into<T>/TryInto<T> impls).

Many of the methods implemented on reth_primitives::Transaction overlap with alloy_consensus::Transaction, so make sure to not include those in the new trait.

Additional context

No response
@emhane emhane added D-good-first-issue Nice and easy! A great choice to get started A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain labels Oct 7, 2024
@emhane emhane mentioned this issue Oct 7, 2024
Open
@edisontim
Copy link
Contributor

Hey @emhane can I get assigned on this one?

@edisontim edisontim linked a pull request Oct 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edisontim edisontim

Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: transaction trait edisontim/reth
2 participants
@emhane @edisontim