Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent specification of Camera/Focuser model in config. #1027

Open
danjampro opened this issue Nov 2, 2020 · 1 comment
Open

Inconsistent specification of Camera/Focuser model in config. #1027

danjampro opened this issue Nov 2, 2020 · 1 comment

Comments

@danjampro
Copy link
Collaborator

danjampro commented Nov 2, 2020

Camera models are specified by file:
panoptes.pocs.camera.zwo

But focuser (and filterwheel) models are specified by class name:
panoptes.pocs.focuser.birger.Focuser

Suggest going with one or the other.

@wtgee
Copy link
Member

wtgee commented Nov 3, 2020

@danjampro where are you seeing this? The first is specifying a namespace for the device and should have defaulted to the default class type for that namespace. But I thought I removed that syntax anyway so that you always need the fully resolved namespace.

The current config has fully resolved, for instance:

POCS/conf_files/pocs.yaml

Lines 90 to 106 in dc330ac

filterwheel:
model: panoptes.pocs.filterwheel.simulator.FilterWheel
filter_names: [ ]
move_time: 0.1 # seconds
timeout: 0.5 # seconds
focuser:
enabled: False
autofocus_seconds: 0.1 # seconds
autofocus_size: 500 # seconds
autofocus_keep_files: False
devices:
- model: panoptes.pocs.camera.gphoto.canon.Camera
name: dslr.00
file_extension: cr2
- model: panoptes.pocs.camera.gphoto.canon.Camera
name: dslr.01
file_extension: cr2

@wtgee wtgee added the focuser label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants