From c9d4c8814bd9510edcafc070a64e2801a0820535 Mon Sep 17 00:00:00 2001 From: Chef Snoopy Date: Fri, 26 Jul 2024 11:21:34 +0800 Subject: [PATCH 1/2] fix: Remove compile warning Now tokenURI function does not use the parameter positionManager. So we can remove compile warning by deleting positionManager --- src/pool-cl/NonfungibleTokenPositionDescriptorOffChain.sol | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pool-cl/NonfungibleTokenPositionDescriptorOffChain.sol b/src/pool-cl/NonfungibleTokenPositionDescriptorOffChain.sol index 4756dd2..be449fb 100644 --- a/src/pool-cl/NonfungibleTokenPositionDescriptorOffChain.sol +++ b/src/pool-cl/NonfungibleTokenPositionDescriptorOffChain.sol @@ -22,6 +22,7 @@ contract NonfungibleTokenPositionDescriptorOffChain is INonfungibleTokenPosition override returns (string memory) { + delete positionManager; return bytes(_baseTokenURI).length > 0 ? string.concat(_baseTokenURI, tokenId.toString()) : ""; } } From c18ac5378b41fd5816e2cdf547bc99ddeb15d011 Mon Sep 17 00:00:00 2001 From: Chef Snoopy Date: Fri, 26 Jul 2024 14:10:33 +0800 Subject: [PATCH 2/2] fix: Remove unused parameter name --- .../NonfungibleTokenPositionDescriptorOffChain.sol | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/pool-cl/NonfungibleTokenPositionDescriptorOffChain.sol b/src/pool-cl/NonfungibleTokenPositionDescriptorOffChain.sol index be449fb..07ad91d 100644 --- a/src/pool-cl/NonfungibleTokenPositionDescriptorOffChain.sol +++ b/src/pool-cl/NonfungibleTokenPositionDescriptorOffChain.sol @@ -16,13 +16,7 @@ contract NonfungibleTokenPositionDescriptorOffChain is INonfungibleTokenPosition } /// @inheritdoc INonfungibleTokenPositionDescriptor - function tokenURI(INonfungiblePositionManager positionManager, uint256 tokenId) - external - view - override - returns (string memory) - { - delete positionManager; + function tokenURI(INonfungiblePositionManager, uint256 tokenId) external view override returns (string memory) { return bytes(_baseTokenURI).length > 0 ? string.concat(_baseTokenURI, tokenId.toString()) : ""; } }