Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] WalletConnect Issue #9673

Open
1 task done
divyangkhatri opened this issue Apr 24, 2024 · 5 comments
Open
1 task done

[BUG] WalletConnect Issue #9673

divyangkhatri opened this issue Apr 24, 2024 · 5 comments
Assignees
Labels
Bug Something isn't working Triage Awaiting team acknowledgement

Comments

@divyangkhatri
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Product

Trade

Current Behavior

We are in the process of integrating our wallet application with your PancakeSwap platform via WalletConnect. During this integration, we have encountered an additional method, wallet_addEthereumChain.
Currently, we are passing the chainId as a parameter in the request (request?.params?.[0]?.chainId). However, we have observed that this approach yields inconsistent results - it works intermittently.

Expected Behavior

I think wallet_addEthereumChain is only for metamask connection. This method doesn't require for connection type walletconnect. So, I think method should be remove when connection type is wallet connect.

Steps To Reproduce

Try to do walletconnect from wallet app locally and observed the SESSION_REQUEST event

Environment

- Device: Macbook Pro
- OS: Mac OS 14.2.1
- Browser: Chrome
- Wallet: WalletConnect combatible wallet (need to check locally to observe the event)

Anything else?

No response

@divyangkhatri divyangkhatri added Bug Something isn't working Triage Awaiting team acknowledgement labels Apr 24, 2024
@divyangkhatri divyangkhatri changed the title [BUG] <title> [BUG] WalletConnect Issue Apr 25, 2024
@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

4 similar comments
@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Triage Awaiting team acknowledgement
Projects
None yet
Development

No branches or pull requests

3 participants