From 897dab5359c6f11c7a0aa2853b76e1daa4d8aa7d Mon Sep 17 00:00:00 2001 From: giomella Date: Mon, 23 Oct 2023 12:12:32 +0200 Subject: [PATCH 1/2] [PRDP-176] updated log to include exception message --- .../generator/service/impl/GenerateReceiptPdfServiceImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImpl.java b/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImpl.java index 5ae2c7b8..58b732e2 100644 --- a/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImpl.java +++ b/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImpl.java @@ -162,7 +162,7 @@ private PdfMetadata generateAndSavePDFReceipt(BizEvent bizEvent, String template PdfEngineResponse pdfEngineResponse = generatePDFReceipt(template, workingDirPath); return saveToBlobStorage(pdfEngineResponse, blobName); } catch (PDFReceiptGenerationException e) { - logger.error("An error occurred when generating or saving the PDF receipt for biz-event {}", bizEvent.getId(), e); + logger.error("An error occurred when generating or saving the PDF receipt for biz-event {}. Error: {}", bizEvent.getId(), e.getMessage(), e); return PdfMetadata.builder().statusCode(e.getStatusCode()).errorMessage(e.getMessage()).build(); } } From b05ee98455b245692160227c2c28bd7eb20c3fbd Mon Sep 17 00:00:00 2001 From: giomella Date: Mon, 23 Oct 2023 12:27:58 +0200 Subject: [PATCH 2/2] [PRDP-176] improve exception message for pdf engine invocation in error --- .../generator/service/impl/GenerateReceiptPdfServiceImpl.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImpl.java b/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImpl.java index 58b732e2..670973a6 100644 --- a/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImpl.java +++ b/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImpl.java @@ -204,7 +204,8 @@ private PdfEngineResponse generatePDFReceipt(ReceiptPDFTemplate template, Path w PdfEngineResponse pdfEngineResponse = pdfEngineClient.generatePDF(request, workingDirPath); if (pdfEngineResponse.getStatusCode() != HttpStatus.SC_OK) { - throw new GeneratePDFException(pdfEngineResponse.getErrorMessage(), pdfEngineResponse.getStatusCode()); + String errMsg = String.format("PDF-Engine response KO (%s): %s", pdfEngineResponse.getStatusCode(), pdfEngineResponse.getErrorMessage()); + throw new GeneratePDFException(errMsg, pdfEngineResponse.getStatusCode()); } return pdfEngineResponse;