Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-1359] fix #78

Merged
merged 1 commit into from
Nov 23, 2023
Merged

[PAGOPA-1359] fix #78

merged 1 commit into from
Nov 23, 2023

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Nov 23, 2023

List of Changes

Remove dueDate check on the particular Payment Option

Motivation and Context

DebtPositionStatus is EXPIRED when maxDueDate has been reached. Thus, a Payment Option is payable as long as all Payment Option within the same Payment Position have not expired.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang self-assigned this Nov 23, 2023
@cap-ang cap-ang requested a review from a team as a code owner November 23, 2023 12:26
@cap-ang cap-ang merged commit 96e2d4b into main Nov 23, 2023
4 of 7 checks passed
@cap-ang cap-ang deleted the PAGOPA-1359-partially-payments branch November 23, 2023 12:26
Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant