Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove replace from transfer response #71

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix: Remove replace from transfer response #71

merged 2 commits into from
Oct 31, 2023

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Oct 31, 2023 •
edited
Loading

List of Changes

  • fix: Remove replace from transfer response

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang self-assigned this Oct 31, 2023
@cap-ang cap-ang requested a review from a team as a code owner October 31, 2023 08:46
@cap-ang cap-ang added the bug Something isn't working label Oct 31, 2023
@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

95.5% 95.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

FedericoRuzzier
FedericoRuzzier approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cap-ang cap-ang merged commit e78d03b into main Oct 31, 2023
1 check passed
@cap-ang cap-ang deleted the PAGOPA-1328-fix-transfer-category-replace branch October 31, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedericoRuzzier FedericoRuzzier FedericoRuzzier approved these changes

Assignees

@cap-ang cap-ang

Labels
bug Something isn't working size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cap-ang @FedericoRuzzier @pagopa-github-bot