[PAGOPA-1800] fix: Update Stamp mapping #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cap-ang
commented
Jun 6, 2024
| @@ -548,8 +563,15 @@ private CtTransferPA getTransferResponse( | |||
| */ | |||
| private CtTransferPAV2 getTransferResponseV2( | |||
| PaymentsTransferModelResponse transfer, StTransferType transferType) { | |||
| CtRichiestaMarcaDaBollo richiestaMarcaDaBollo = | |||
| customizedModelMapper.map(transfer.getStamp(), CtRichiestaMarcaDaBollo.class); | |||
| Stamp stamp = transfer.getStamp(); | |||
There was a problem hiding this comment.
here the real changes
cap-ang
commented
Jun 6, 2024
|
|
||
|
|
||
| @Test | ||
| void paGetPaymentV2StampTest() |
There was a problem hiding this comment.
here the new test with Stamp case
|
This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Comment this PR with update_code to update |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Stampvariables: only if all three variables are different fromnullcan created and returnedrichiestaMarcaDaBollohashDocumentstring tohashDocumentobyte arraypaGetPaymentV2StampTestMotivation and Context
When Stamp values are null in the GET paymentoptions/
{nav}responsepaGetPaymentV2must return a response withoutrichiestaMarcaDaBollopaGetPaymentis not affected because doesn't haverichiestaMarcaDaBolloHow Has This Been Tested?
manually test environment UAT, use case:
payment-optionwith two transfer (1 with Stamp, 1 without Stamp only IBAN)payment-optionvia checkoutScreenshots (if appropriate):
Types of changes
Checklist: