-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAGOPA-1800] fix: Update Stamp mapping #105
Conversation
@@ -548,8 +563,15 @@ private CtTransferPA getTransferResponse( | |||
*/ | |||
private CtTransferPAV2 getTransferResponseV2( | |||
PaymentsTransferModelResponse transfer, StTransferType transferType) { | |||
CtRichiestaMarcaDaBollo richiestaMarcaDaBollo = | |||
customizedModelMapper.map(transfer.getStamp(), CtRichiestaMarcaDaBollo.class); | |||
Stamp stamp = transfer.getStamp(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here the real changes
|
||
|
||
@Test | ||
void paGetPaymentV2StampTest() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here the new test with Stamp case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Comment this PR with update_code to update |
Quality Gate failedFailed conditions |
List of Changes
Stamp
variables: only if all three variables are different fromnull
can created and returnedrichiestaMarcaDaBollo
hashDocument
string tohashDocumento
byte arraypaGetPaymentV2StampTest
Motivation and Context
When Stamp values are null in the GET paymentoptions/
{nav}
responsepaGetPaymentV2
must return a response withoutrichiestaMarcaDaBollo
paGetPayment
is not affected because doesn't haverichiestaMarcaDaBollo
How Has This Been Tested?
manually test environment UAT, use case:
payment-option
with two transfer (1 with Stamp, 1 without Stamp only IBAN)payment-option
via checkoutScreenshots (if appropriate):
Types of changes
Checklist: