Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagopa 1695 sviluppo pa send rt long term reliability #102

Merged

Conversation

FedericoRuzzier
Copy link
Contributor

List of Changes

Adding retry mechanism with queue for paSendRT and paSendRTV2

Motivation and Context

Addition needed to add the retry mechanism for this call

How Has This Been Tested?

Manually and through junit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the enhancement New feature or request label Apr 30, 2024
@FedericoRuzzier FedericoRuzzier requested a review from a team as a code owner April 30, 2024 15:12
}
public Document getXMLDocument(String xmlString) {
try {
DocumentBuilderFactory factory = DocumentBuilderFactory.newDefaultNSInstance();

Check failure

Code scanning / SonarCloud

XML parsers should not be vulnerable to XXE attacks

<!--SONAR_ISSUE_KEY:AY9SFYngWv1leEpAQlUB-->Disable access to external entities in XML parsing. <p>See more on <a href="https://sonarcloud.io/project/issues?id=pagopa_pagopa-gpd-payments&issues=AY9SFYngWv1leEpAQlUB&open=AY9SFYngWv1leEpAQlUB&pullRequest=102">SonarCloud</a></p>
helm/values-dev.yaml Outdated Show resolved Hide resolved
helm/values-prod.yaml Outdated Show resolved Hide resolved
helm/values-uat.yaml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented May 8, 2024

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

github-actions bot commented May 8, 2024

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

Copy link

sonarcloud bot commented May 8, 2024

Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

@FedericoRuzzier FedericoRuzzier merged commit c5ac6bd into main May 8, 2024
11 of 14 checks passed
@FedericoRuzzier FedericoRuzzier deleted the PAGOPA-1695-sviluppo-pa-send-rt-long-term-reliability branch May 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants