Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Webhook Button ignores consumer/provider settings #718

Open
2 of 3 tasks
huehnerlady opened this issue Sep 4, 2024 · 4 comments
Open
2 of 3 tasks

Test Webhook Button ignores consumer/provider settings #718

huehnerlady opened this issue Sep 4, 2024 · 4 comments
Labels
smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear

Comments

@huehnerlady
Copy link

Pre issue-raising checklist

I have already (please mark the applicable with an x):

  • Upgraded to the latest Pact Broker OR
  • Checked the CHANGELOG to see if the issue I am about to raise has been fixed
  • Created an executable example that demonstrates the issue using either a:
    • Dockerfile
    • Git repository with a Travis or Appveyor (or similar) build

Software versions

  • Pactflow hosted version

Expected behaviour

I have this webhook page:
image

When I select a specific provider and click Test Webhook, I expect a webhook call from all possible consumer/provider pairs with this provider.

Example:
I have 30 consumers and 10 providers.

Provider A has 3 consumers. Then I would expect 3 webhooks to be send out.

Actual behaviour

It seems that every possible consumer/provider constellation is send out spamming the endpoint receiving the webhook call.

Steps to reproduce

  • Have 2 providers and 2 consumers in a broker, one provider should have each one consumer
  • Create webhook
  • select 1 provider
  • run Test Webhook

You should just get 1 call as the chosen provider has only one consumer. But there will be 2.

Additional information

This issue was initially discussed in the pact slack workspace on the 3rd September 2024.
The conversation can be found here

In there it was pointed out that the logic would be somewhere in the trigger_service.rb.

@mefellows
Copy link
Member

Thanks for this. It looks like you also had this option set on the account (I can see a lot of the webhooks that were triggered were actually caused by this setting, and not the other).

Screenshot 2024-09-04 at 10 06 11 PM

@huehnerlady
Copy link
Author

@mefellows I did in between, but even without that checkbox it still spams the endpoint when testing it

@YOU54F
Copy link
Member

YOU54F commented Sep 16, 2024

Hey Ruth,

Could you try via an API call, or with the pact_broker-client.

https://github.com/pactflow/example-provider/blob/44af7987b6a7bd992ec4b38f284c109765f45350/Makefile#L98

I believe there may be an issue with the webhook button in pactflow triggering multiple executions that I can recreate, but I get the expected behaviour triggering the webhook directly via API

@mefellows mefellows added the smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear label Sep 30, 2024
Copy link

🤖 Great news! We've labeled this issue as smartbear-supported and created a tracking ticket in PactFlow's Jira (PACT-2563). We'll keep work public and post updates here. Meanwhile, feel free to check out our docs. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear
Projects
None yet
Development

No branches or pull requests

3 participants