Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QtKeychain in 3rdparty #6004

Closed
hefee opened this issue Sep 7, 2017 · 3 comments
Closed

QtKeychain in 3rdparty #6004

hefee opened this issue Sep 7, 2017 · 3 comments
Assignees
Milestone

Comments

@hefee
Copy link
Contributor

hefee commented Sep 7, 2017

Why you include an old version of qtkeychain 0.5.0 inside 3rdparty with 2.3.3?

0.5.0 was released at 2015! But the newest 0.8.0 has for example an issue, that at least stops Debian of shipping it:
frankosterfeld/qtkeychain#99

Please do not include every library,that you depend on in 3rdparty. It makes it much harder for distributions to package owncloud-client, because distributions needs to unbundle the complete mess afterwards.
And at least document we you add a specific lib to 3rdparty and document this, why you do this!

@guruz guruz self-assigned this Sep 8, 2017
@jnweiger
Copy link
Contributor

jnweiger commented Sep 8, 2017

Linux builds use qtkeychain-0.7.0 -- maybe we can just update that client/src/3rdparty/qtkeychain to use the same source and configure settings than we use in https://build.opensuse.org/package/show/isv:ownCloud:devel:Qt562:templatized/ocqt562-qt5keychain

Windows builds use mingw32-qt5keychain-0.6.2-1.3 from isv:ownCloud:toolchains:mingw:win32:2.3

mac builds seem to have 0.6.2 if I my mac-foo serves me right.

I suggest to delete qtkeychain source from 3rdparty. It seems to be unused :-)

@guruz
Copy link
Contributor

guruz commented Sep 8, 2017

Funny, this seems to be added mistakeninly in c8b3df6 probably when i tried to do #1416

guruz added a commit that referenced this issue Sep 8, 2017
@guruz guruz added this to the 2.4.0 milestone Sep 8, 2017
@guruz
Copy link
Contributor

guruz commented Sep 8, 2017

Should be removed for 2.4 :)

@guruz guruz closed this as completed Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants