-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification of the setup for the static backend is broken #92
Comments
I reemplemented the verification completely, since the old strategy was blocked by security changes in the newer OC core. This really was a tough task! To work through all those layers, options and security hassles was quite a challenge. But as always it also allowed to learn a lot :-) @fredl99 you want to give that one a try before I merge it? Testing this is pretty hard for me, since there are so many different setups. So I am more than happy for all feed. |
Hm, looks like there is still some issue with cross domain validation. 😢 : |
Well, it says, "Setup valid and usable" if i don't change my settings. Looks very fine so far, but also a bit mysterious because there's no explanation as to why it's valid or not. Has a touch of black magic 😈 Also the "test-link" is shown although it can't be selected (clicked). |
Valid and usable is what you want. Not more, not less. And yes, the url example is shown and updated according to the input. Indeed it is not clickable any more, since clicking it is not required any more compared to before where you had to click to verify the setting. Maybe I should remove the text underline? OK... |
Yeah, right :)
Good to know, but it should say so. Although I don't know exactly how this verification is done, I suppose it takes a few steps. How about displaying them, along with a green checkmark / red cross? This way one could guess where to look at, if it doesn't work.
Yes, otherwise it would look as if something doesn't work. There's a second one in the dialog-box of the table. BTW: There's a "hidden" link to the tracking extension a few lines below within the admin's dialog:
That doesn't do anything, too. It only turns the cursor into a pointer. |
BTW:
Wouldn't this solve issue #89 too? |
Fixed the visualization of backend url examples in the settings and the preferences dialogs. No more underlining, some other cleanups as well. |
Sorry, but I fail to see the ""hidden" link to the tracking extension" in the admin dialog... |
This reimplementation does not resolve issue #89 too. |
It's getting better and better. I'm impressed :)
|
Merged into arkascha/owncloud-shorty//stable7 and into owncloud/shorty//stable7 |
sigh there still is an issue with cross domain verification requests. |
The verification implementation got a streamlining overhaul, it appears to be working reliably across domain borders now. This is required when using a different domain as a static backend base than the domain owncloud uses. |
Will be released as part of Shorty version 0.5. |
Apparently since porting to OC-7 the verification feature for the setup of the static backend base in the settings dialog is broken. It is one of many thing broken by changes in OC-core.
The problem here is that those validation attempts often are requests to third party servers, since that base url often is located on another server (shorted domain name). This violates the same origin policy.
An obvious solution would be to verify the setup on the server side, but that would tell little: the backend has to be used by clients, not by the server.
The text was updated successfully, but these errors were encountered: