Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish to windows winget package manager #583

Open
felixsanz opened this issue Dec 18, 2023 · 2 comments
Open

publish to windows winget package manager #583

felixsanz opened this issue Dec 18, 2023 · 2 comments
Labels
enhancement New feature or request PR-welcome Suggestion was approved, but now we need someone to volunteer for doing it

Comments

@felixsanz
Copy link

can you publish on winget package manager please?

@felixsanz felixsanz added the enhancement New feature or request label Dec 18, 2023
@AntoniosBarotsis
Copy link
Contributor

I was doing a bit of reading to figure out what needs to be done for this and man why are these package managers always such a pain to publish to. Anyway, a rough outline of what I found so far:

  • We need an installer and wix seems to be a common one. Conveniently, cargo-wix exists which helps a lot and just running cargo wix init and cargo wix builds you an installer.

    For this you need choco install wixtoolset -y and might need dotnet tool install --global wix.

  • I looked into NuShell to see how they do it and their release job is pretty simple.

  • This release job assumes the installer files are present in the GitHub release. You are already doing roughly what is needed in the create-draft-release-with-artifacts CI job, I think if we ran cargo-wix here to generate the installer and add it to the release assets it "should all work fine with zero problems✨" which is always how these things go right :)

Also do note that wingetcreate update needs a version to be published beforehand so even if we implemented this now, we would only be able to test the CD job a release later (of course you could also just bump the patch version for the sake of testing).

Lastly, it seems that you can publish installers for all OSes on Winget? Not sure if that's actually the case but also not sure if it would be worth the extra hassle since ouch is already published for a plethora of Linux distros and I doubt anyone not on Windows would use Winget.

It also seems like NuShell has had issues with their CD job because of their binaries being renamed accidentally at one point or another which were apparently hard to debug, it might be a good idea to add sanity checks to prevent this (maybe log errors with something like this?).

@marcospb19
Copy link
Member

can you publish on winget package manager please?

It might be surprising, but Ouch maintainers didn't create a single package for Ouch! That was all done by random people who wanted to help. <3

Thank you so much for the info @AntoniosBarotsis, I'll mark this as "PR-welcome" for anyone who wants to tackle it.

Note: I don't own a Windows environment so I'd expect whoever is making this PR to "check if it works" for us, if it isn't much to ask, also check if it keeps working after the very next Ouch update.

@marcospb19 marcospb19 added help wanted We would appreciate being helped to solve this PR-welcome Suggestion was approved, but now we need someone to volunteer for doing it and removed help wanted We would appreciate being helped to solve this labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR-welcome Suggestion was approved, but now we need someone to volunteer for doing it
Projects
None yet
Development

No branches or pull requests

3 participants