Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for --format .tar.gz outputs empty extension #517

Closed
marcospb19 opened this issue Sep 16, 2023 · 1 comment · Fixed by #519
Closed

Error message for --format .tar.gz outputs empty extension #517

marcospb19 opened this issue Sep 16, 2023 · 1 comment · Fixed by #519
Assignees
Labels
bug Something isn't working

Comments

@marcospb19
Copy link
Member

marcospb19 commented Sep 16, 2023

Version

0.4.2

Description

When running

ouch compress LICENSE output --format .tar.gz

Current Behavior

ouch outputs

[ERROR] Invalid archive format
 - Unsupported extension:

Expected Behavior

Properly handle the --format flag with the leading dot.

OR

Output this instead:

[ERROR] Invalid archive format
 - Unsupported extension: .tar.gz
@marcospb19 marcospb19 added the bug Something isn't working label Sep 16, 2023
@marcospb19 marcospb19 self-assigned this Sep 16, 2023
@marcospb19 marcospb19 changed the title Error with --format outputs empty extension Error message for --format .tar.gz outputs empty extension Sep 16, 2023
@marcospb19
Copy link
Member Author

marcospb19 commented Sep 16, 2023

I'll take this one after #515 is merged so I can add tests for it to avoid regression.

EDIT: actually now waiting for #518 to reuse some of its code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant