Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests failing #9

Open
detj opened this issue Jul 22, 2016 · 1 comment
Open

tests failing #9

detj opened this issue Jul 22, 2016 · 1 comment

Comments

@detj
Copy link

detj commented Jul 22, 2016

2 of the 7 tests are failing. Tested using node 5.7.0 & node 6.3.1

Here's the output

draco:cls-middleware detj$ npm test

> [email protected] test /Users/detj/tmp/cls-middleware
> tap test/*.tap.js

not ok test/basic-express.tap.js ........................ 5/7
    Command: "/usr/local/bin/node basic-express.tap.js"
    TAP version 13
    ok 1 Should not throw
    not ok 2 value is default
      ---
        file:   /Users/detj/tmp/cls-middleware/test/basic-express.tap.js
        line:   22
        column: 9
        stack:
          - |
            getCaller (/Users/detj/tmp/cls-middleware/node_modules/tap/lib/tap-assert.js:418:17)
          - |
            assert (/Users/detj/tmp/cls-middleware/node_modules/tap/lib/tap-assert.js:21:16)
          - |
            Function.equal (/Users/detj/tmp/cls-middleware/node_modules/tap/lib/tap-assert.js:162:10)
          - |
            Test._testAssert [as equal] (/Users/detj/tmp/cls-middleware/node_modules/tap/lib/tap-test.js:87:16)
          - |
            Object.handle (/Users/detj/tmp/cls-middleware/test/basic-express.tap.js:22:9)
          - |
            next (/Users/detj/tmp/cls-middleware/node_modules/connect/lib/proto.js:193:15)
          - |
            /Users/detj/tmp/cls-middleware/middleware.js:11:7
          - |
            Namespace.run (/Users/detj/tmp/cls-middleware/node_modules/continuation-local-storage/context.js:48:5)
          - |
            Object.handle (/Users/detj/tmp/cls-middleware/middleware.js:10:8)
          - |
            next (/Users/detj/tmp/cls-middleware/node_modules/connect/lib/proto.js:193:15)
        found:  ~
        wanted: 1
        type:
          found:  undefined
          wanted: undefined
      ...
    not ok 3 value was incremented
      ---
        file:   /Users/detj/tmp/cls-middleware/node_modules/express/lib/router/index.js
        line:   164
        column: 37
        stack:
          - |
            getCaller (/Users/detj/tmp/cls-middleware/node_modules/tap/lib/tap-assert.js:418:17)
          - |
            assert (/Users/detj/tmp/cls-middleware/node_modules/tap/lib/tap-assert.js:21:16)
          - |
            Function.equal (/Users/detj/tmp/cls-middleware/node_modules/tap/lib/tap-assert.js:162:10)
          - |
            Test._testAssert [as equal] (/Users/detj/tmp/cls-middleware/node_modules/tap/lib/tap-test.js:87:16)
          - |
            /Users/detj/tmp/cls-middleware/test/basic-express.tap.js:29:9
          - |
            callbacks (/Users/detj/tmp/cls-middleware/node_modules/express/lib/router/index.js:164:37)
          - |
            param (/Users/detj/tmp/cls-middleware/node_modules/express/lib/router/index.js:138:11)
          - |
            pass (/Users/detj/tmp/cls-middleware/node_modules/express/lib/router/index.js:145:5)
          - |
            Router._dispatch (/Users/detj/tmp/cls-middleware/node_modules/express/lib/router/index.js:173:5)
          - |
            Object.router (/Users/detj/tmp/cls-middleware/node_modules/express/lib/router/index.js:33:10)
        found:  NaN
        wanted: 2
      ...
    ok 4 no error found
    ok 5 got OK response
    ok 6 body was as expected
    ok 7 test/basic-express.tap.js

    1..7
    # tests 7
    # pass  5
    # fail  2

total ................................................... 5/7

not ok
npm ERR! Test failed.  See above for more details.

I just cloned the project and ran npm test. Is this really an issue or did I miss something?

@oleiba
Copy link

oleiba commented Aug 10, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants