Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirusTotal Scan #38

Open
1 task
AchillesHeir opened this issue Sep 13, 2024 · 0 comments
Open
1 task

VirusTotal Scan #38

AchillesHeir opened this issue Sep 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@AchillesHeir
Copy link
Contributor

Problem

Time was an issue when in developement and wasn't able to integrate the functionality of getting the external API scan from VirusTotal into the extension. The difficulty is creating the right listeners and message senders to invoke and display the results. The code iteself needs to be improved upon and multiple UI elements need to be added to the results panel of each scan. The code for displaying the results needs to be added to the UI as well as instructions.

Solution

The idea was to have a stepper in the MUI to explain how each user can go to the website and get an API key, and store that key in the setting.json (a more secure way than just adding the key directly into an input box). The functionality to grab that key is commented out in the virusTotal folder.

Also, the functionality itself could be improved upon. Currently the code waits 30 seconds before requesting the results, which works a lot of the time but could be improved on. There is a way to make requests to check if the status is complete. This could possibly be done every 20 or 30 seconds.

Additional information

No response

👨‍👧‍👦 Contributing

  • 🙋‍♂️ Yes, I'd love to make a PR to implement this feature!
@AchillesHeir AchillesHeir added the enhancement New feature or request label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant