From 56fa662d8631daa9efc8b5589e0220c564bd25e1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lars=20G=C3=B6ttgens?= <lars.goettgens@rwth-aachen.de>
Date: Fri, 11 Oct 2024 15:05:37 +0200
Subject: [PATCH] More type stability for GSets

---
 src/Groups/gsets.jl | 14 +++++++-------
 src/Groups/types.jl |  4 ++--
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/Groups/gsets.jl b/src/Groups/gsets.jl
index edb96f7c4222..9f81893c9aaf 100644
--- a/src/Groups/gsets.jl
+++ b/src/Groups/gsets.jl
@@ -36,7 +36,7 @@ The fields are
 - the seeds (something iterable of eltype `S`) whose closure under the action is the G-set
 - the dictionary used to store attributes (orbits, elements, ...).
 """
-@attributes mutable struct GSetByElements{T,S} <: GSet{T}
+@attributes mutable struct GSetByElements{T,S} <: GSet{T,S}
     group::T
     action_function::Function
     seeds
@@ -229,7 +229,7 @@ end
 #TODO: Compute membership without writing down all elements,
 #      using what is called `RepresentativeAction` in GAP.
 
-function Base.in(omega, Omega::GSetByElements)
+function Base.in(omega::S, Omega::GSetByElements{T,S}) where {T,S}
     omega in Omega.seeds && return true
     return omega in elements(Omega)
 end
@@ -256,12 +256,12 @@ as_gset(G::T, Omega) where T<:Union{GAPGroup,FinGenAbGroup} = as_gset(G, ^, Omeg
 ##    not via the action function stored in the G-set,
 ##  - write something like `orbit(omega)`, `stabilizer(omega)`.
 
-struct ElementOfGSet
-    gset::GSet
-    obj::Any
+struct ElementOfGSet{T, S, G <: GSet{T, S}}
+    gset::G
+    obj::S
 end
 
-function (Omega::GSet)(obj::Any)
+function (Omega::GSet{T, S})(obj::S) where {T, S}
     return ElementOfGSet(Omega, obj)
 end
 
@@ -509,7 +509,7 @@ The fields are
 - the (left or right) transversal, of type `SubgroupTransversal{T, S, E}`,
 - the dictionary used to store attributes (orbits, elements, ...).
 """
-@attributes mutable struct GSetBySubgroupTransversal{T, S, E} <: GSet{T}
+@attributes mutable struct GSetBySubgroupTransversal{T, S, E} <: GSet{T,GroupCoset{T, E}}
     group::T
     subgroup::S
     side::Symbol
diff --git a/src/Groups/types.jl b/src/Groups/types.jl
index b1c773c3d3b5..c0e3ede05a83 100644
--- a/src/Groups/types.jl
+++ b/src/Groups/types.jl
@@ -478,7 +478,7 @@ end
 
 ################################################################################
 
-abstract type GSet{T} end
+abstract type GSet{T,S} end
 
 
 ################################################################################
@@ -493,7 +493,7 @@ abstract type GSet{T} end
 It can be either the conjugacy class of an element or of a subgroup of type `S`
 in a group `G` of type `T`.
 """
-abstract type GroupConjClass{T, S} <: GSet{T} end
+abstract type GroupConjClass{T,S} <: GSet{T,S} end
 
 
 ################################################################################