Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openqa-mon] starting program without any option should give useful information #169

Closed
ilmanzo opened this issue Aug 27, 2024 · 5 comments · Fixed by #174
Closed

[openqa-mon] starting program without any option should give useful information #169

ilmanzo opened this issue Aug 27, 2024 · 5 comments · Fixed by #174

Comments

@ilmanzo
Copy link
Contributor

ilmanzo commented Aug 27, 2024

When I start the program without any command line option I get a screen like this

image

what are those tests and where they came from ? It may be a confusing UX since nobody asked to monitor those jobs.

a couple proposal for possibile more useful when user enters an empty command line:

  • show the jobs from last time (this means we need to persist the previous query in some way)
  • show help page and highlight the mandatory command line parameters

WDYT ?

@Martchus
Copy link

What weird response is that. That really sounds like someone completely unrelated to this project is trying to spread malware. If you agree, we should report/block the user and delete the comment.

The actual question I cannot answer but I also have no real opinion on what should happen on a call without arguments.

@ilmanzo
Copy link
Contributor Author

ilmanzo commented Aug 27, 2024

What weird response is that. That really sounds like someone completely unrelated to this project is trying to spread malware. If you agree, we should report/block the user and delete the comment.

yes I reported also the spam/malware to github, thanks 👍🏻

The actual question I cannot answer but I also have no real opinion on what should happen on a call without arguments.

@grisu48
Copy link
Collaborator

grisu48 commented Sep 10, 2024

@ilmanzo I cannot reproduce this issue, when I simply run openqa-mon then I get the help message (as it should be):

phoenix@racetrack-7290:~> openqa-mon
Usage: openqa-mon [OPTIONS] REMOTE
  REMOTE can be the directlink to a test (e.g. https://openqa.opensuse.org/t123)
  or a job range (e.g. https://openqa.opensuse.org/t123..125 or https://openqa.opensuse.org/t123+2)

OPTIONS

  -h, --help                       Print this help message
  --version                        Display program version
  -j, --jobs JOBS                  Display information only for the given JOBS
                                   JOBS can be a single job id, a comma separated list (e.g. 42,43,1337)
                                   or a job range (1335..1339 or 1335+4)
  -c,--continuous SECONDS          Continuously display stats, use rabbitmq if available otherwise status pulling
  -e,--exit                        Exit openqa-mon when all jobs are done (only in continuous mode)
                                   Return code is 0 if all jobs are passed or softfailing, 1 otherwise.
  -b,--bell                        Bell notification on job status changes
  -n,--notify                      Send desktop notifications on job status changes
  --no-bell                        Disable bell notification
  --no-notify                      Disable desktop notifications
  -m,--monitor                     Enable bell and desktop notifications
  -s,--silent                      Disable bell and desktop notifications

  -f,--follow                      Follow jobs, i.e. replace jobs by their clones if available
  --no-follow                      Don't follow jobs
  --rabbitmq                       Explicitly enable rabbitmq (experimental!!)
  --rabbit FILE                    Explicitly enable rabbitmq and load configurations from FILE
  --no-rabbit                      Don't use RabbitMQ, even if available
  -p,--hierarchy                   Show job hierarchy (i.e. children jobs)
  --hide-state STATES              Hide jobs with that are in the given state (e.g. 'running,assigned')

  --config FILE                    Read additional config file FILE
  -i, --input FILE                 Read jobs from FILE (additionally to stdin)

2023, https://github.com/grisu48/openqa-mon

Could you please post the command that gives you this screenshot?

@ilmanzo
Copy link
Contributor Author

ilmanzo commented Sep 10, 2024

I guess is caused (and reproducible) by having a DefaultRemote entry in openqa-mon.conf :

## Default remote to use, if nothing is defined
DefaultRemote = http://openqa.opensuse.org

when I comment it, I get the help screen; when present, openqa-mon starts to fetch unwanted jobs from the remote.

So could be feasible to just ignore that setting when command line is empty?

@grisu48
Copy link
Collaborator

grisu48 commented Oct 1, 2024

#174 fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@grisu48 @ilmanzo @Martchus and others