Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination logic does not update on terminal resize #158

Open
ilmanzo opened this issue Aug 19, 2024 · 3 comments
Open

Pagination logic does not update on terminal resize #158

ilmanzo opened this issue Aug 19, 2024 · 3 comments

Comments

@ilmanzo
Copy link
Contributor

ilmanzo commented Aug 19, 2024

After #157 is merged, there is still a leftover glitch; when you have a small terminal (let's say 10 lines) and you enlarge it, the page recalc logic doesn't trigger immediately.

To have a full responsive application we'd need to intercept the terminal resize event and act accordingly, but it would be easier to just use a proper terminal library, like https://github.com/charmbracelet/bubbletea .

The introduction of a terminal lib requires a pretty large re-design of the program but would also enable scrolling and more interactivity, like the feature to select and cancel a job and so on. Also it would promote a clean separation between data and presentation.

For reference, I wrote a small blog post on a very simple example.

@grisu48
Copy link
Collaborator

grisu48 commented Aug 19, 2024

https://github.com/charmbracelet/bubbletea is amazing, however I'm a bit hesitant to change the overall TUI structure of this project at this point in time. Several people are using it now on a daily basis and I would feel that this is a rather big change in a tool that they expect to work.

I'm not opposing the idea in general, in fact I played with the idea myself a couple of times already. I'm just saying, we need to be very careful what we're doing here.

@ilmanzo
Copy link
Contributor Author

ilmanzo commented Aug 19, 2024

I agree such change would need some experiments; BTW another cool candidate could be

or

maybe we can prepare a 2.0 branch / POC or leave the tool as-is and tryout new ideas on a separate openqa-mon-ng :)

@grisu48
Copy link
Collaborator

grisu48 commented Aug 19, 2024

We can talk about that, yes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants