[FEATURE REQUEST] add a console button on 'Service details > Tasks > Task details' page

[opera443399]

Intro
as we discussed on #1242
Service S1 have N Containers, we want to open each Container's Console, things become more complicated when I know #461 (seems as no due date), maybe I should do sth. as the first step.

I want to add a console on 'Service details > Tasks > Task details' page

Changes I made

1. on 'Service details > tasks' page, open 'Task details' with new tab.
2. on 'Task details' page, add a container console button, with a tooltip for failure msg as given below.
3. click the button will open a new tab for 'Container console' page.
   if the container is not running on active endpoint, then we can see a notification:
   'Failure: Docker container identifier not found'
   what we need to do is a endpoint switch.
4. if we switch the endpoint, then we notify the new endpoint name instead of goto dashboard, after the page reload, WYSIWYG.
5. if we switched to a swarm worker node, a switch back to swarm manager node operation is needed.
6. after all, the UX is a little bad, but it works for me.

POC

mkdir /data/portainer_dev
docker run -d -p 9001:9000 -v /var/run/docker.sock:/var/run/docker.sock -v /data/portainer_dev:/data --name portainer_dev opera443399/portainer:dev-feat-add-container-console-on-task-details

Any help would be appreciated.

[deviantony]

What if the endpoint of the worker is not available? The UX is quite bad indeed, I reckon that's a workaround but right now, I'd rather not have this implemented this way.

The work on #461 is definitely the way to go here, though as our dev funds & resources are limited, it's not a priority at the moment.

I'll close this issue as this is not the way we want it to be integrated in Portainer. I know that this is a convenient solution to you but you'll have to wait on the equivalent of #461, sorry.

[opera443399]

@deviantony thanks for letting me know the work on #461 is definitely the way to go.
I know it's not the priority at the moment, just a way to show what kind of feature we might need in the future.

And I'm new to open issue and PR on github, so I wonder if this is the right way to open an issue and PR here , after reading this: contributing

[deviantony]

Hey @opera443399

This is definitely the right way to open an issue and PR. Though, to avoid any work that would not be merged (such as this one), the usual flow is the following:

• You open an issue and report a bug or ask for a feature request
• We discuss it (this step is important) both functionally and technically and we agree on a solution
• You (or any contributor) open a new PR with an implementation for the bug fix / feature request

As you can see here, you went straight from step 1 to 3 without asking for our input... we could have pointed you to the fact that the functional solution was not what we expected before you opened a PR.

You can join us on Slack via https://portainer.io/slack/ if you have more questions or need a live support as well.

[mrmachine]

@deviantony seems like the requested feature is still missing (open console from task detail page, perhaps also task list on stack/service detail page), and that only the proposed implementation of that feature here was the reason this issue was closed/rejected.

After #461 is implemented, will it become easier to implement console/logs/stats buttons for stack/service task list/detail, like we do in the containers list?

Or am I missing some meaningful distinction between task/container that makes it not appropriate? I believe the only tasks Docker Swarm currently implements are containers, although they do say a task could potentially one day be for some other non-container operation. Even then, we could show the console/logs/stats buttons only for container tasks.

[deviantony]

@mrmachine yes, once #461 is out we'll be able to link tasks & containers, thus give the ability to inspect & access stats/logs/console from a task.

[mrmachine]

@deviantony should this be re-opened now that #461 is out, and the console link is still missing from the task detail page?

[deviantony]

@mrmachine indeed.