Implement CFDP directory listing #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a virtualenv generated by direnv, pylama will try to scan all the packages in there if it's not ignored.
The only weird bit is that since it's a proxy request it'll send a final acknowledge back, similar to a proxy file transfer. That's not in the spec, but I can't see a way to distinguish between directory and file given the tools available.
This splits all the fixes (currently related to upstream inconsistently using the filestore in its implementation) out into protocols/cfdp.py. From before this moves the CrcHelper from edl.py to cfdp.py, and adds a new VfsSourceHandler that fixes up a couple internal methods. Finally this replaces the PrefixedFilestore with CacheStore.
ryanpdx
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the CFDP 6.3.3 directory listing request and enables the fwrite_cache based filestore. There were a number of bugs in the upstream implementation that had to be worked around. There's also the related edl_file_upload.py flag
-drto run it from the ground side.