Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: "User requests password reset" #247

Open
tgraupne opened this issue Apr 24, 2020 · 6 comments
Open

Flaky test: "User requests password reset" #247

tgraupne opened this issue Apr 24, 2020 · 6 comments
Labels
bug Something isn't working priority-medium

Comments

@tgraupne
Copy link
Member

Currently, this test is always executed with one specific user.
Hence, it can run into API limits of the Google Reset Password API

@JakobEdding
Copy link
Contributor

JakobEdding commented Apr 27, 2020

Are you explicitly looking for a solution to keep testing against a real firebase instance (external resource) or would it be ok to mock firebase completely? Edit: the latter would be better practice imo

@tgraupne
Copy link
Member Author

tgraupne commented Apr 27, 2020

Are you explicitly looking for a solution to keep testing against a real firebase instance (external resource) or would it be ok to mock firebase completely?

For me personally, mocking firebase would be great 👍

The possibility to mock firebase would help us in a lot of test cases actually.

@kenodressel, @florianschmidt1994, @jagaSto, @Maurice22, what do you think?

@mauriceackel
Copy link
Member

For me this would be fine. Especially if it would make it easier to setup specific tests.

@JakobEdding
Copy link
Contributor

Any thoughts on this @kenodressel, @florianschmidt1994, @jagaSto?

@kenodressel
Copy link
Collaborator

kenodressel commented May 3, 2020

I think a firebase mock would be a great solution but I currently don't see any resources on our side to bring this into reality. If you @jakob-ed would like to have a go at this, feel free, we should be easily able to answer your questions :)

@JakobEdding
Copy link
Contributor

Firstly, sorry for the late response! I don't want to commit on it right now because of other things I'm doing. When I find the time, I will play around with it a bit and if something seems promising, will ask you to assign me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium
Projects
None yet
Development

No branches or pull requests

4 participants