Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FilteredList useEffect hook #210

Open
janikga opened this issue Apr 5, 2020 · 2 comments
Open

Refactor FilteredList useEffect hook #210

janikga opened this issue Apr 5, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request priority-low

Comments

@janikga
Copy link
Collaborator

janikga commented Apr 5, 2020

Currently, we need to disable the exhaustive-deps rule to make the build process work (see #205 )
The long-term solution instead is to refactor this component, and get rid of this hack :)
resources:

@kenodressel
Copy link
Collaborator

kenodressel commented May 6, 2020

This might cause unnecessary renderings and therefore decreases overall performance

@mauriceackel
Copy link
Member

@jagaSto @kenodressel Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low
Projects
None yet
Development

No branches or pull requests

4 participants