Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename start to pos #143

Open
iskandr opened this issue Apr 18, 2016 · 4 comments
Open

Rename start to pos #143

iskandr opened this issue Apr 18, 2016 · 4 comments

Comments

@iskandr
Copy link
Contributor

iskandr commented Apr 18, 2016

In service of using names that more close match VCFs, let's use pos or position instead of start.

@timodonnell @arahuja @tavinathanson Opinions?
@hammer
Copy link

hammer commented Apr 18, 2016

I'm not a fan of abbreviations so I'd vote for position if you're going to change the name.

@tavinathanson
Copy link
Contributor

Does that make end confusing?

@iskandr
Copy link
Contributor Author

iskandr commented Sep 2, 2016

@tavinathanson In #173 I started adding properties like trimmed_base1_start to get as specific as possible with which positions get used. What do you think of that?

@iskandr
Copy link
Contributor Author

iskandr commented Sep 13, 2016

Added trimmed_base1_start and trimmed_base1_end as aliases in #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hammer @iskandr @tavinathanson