Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Add tests to mock_tracer #91

Open
jhorowitz opened this issue Nov 30, 2017 · 2 comments
Open

Add tests to mock_tracer #91

jhorowitz opened this issue Nov 30, 2017 · 2 comments

Comments

@jhorowitz
Copy link
Contributor

Mock tracer has no tests which is important for something which is used to test other components.

@jhorowitz
Copy link
Contributor Author

I'm happy to take this one.

@yurishkuro
Copy link
Member

at minimum we should have this in unittest.js

import { MockTracer } from '../mock_tracer';

// Run the tests on the Mock Tracer.
describe('MockTracer Compatibility', () => {
    apiCompatibilityChecks(() => new MockTracer());
});

However, this currently fails because mock tracer does not implement propagation, which it does in other languages (otherwise it's not possible to use MockTracer for testing framework instrumentations).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants