This repository has been archived by the owner on May 23, 2023. It is now read-only.

Simplify spans with default tags? #65

Open

robsimmons opened this issue Mar 17, 2017 · 0 comments

robsimmons commented Mar 17, 2017

Either one of two (backwards non-compatible) changes would make things easier for implementers:

Have the default Tracer.startSpan implementation call Span.addTags after calling the Span constructor.
Specify that addTags has no effect if passed a falsy value, and have the default Span.addTags implementation perform this check. Then the Span constructor can just call this.addTags(fields && fields.tags).

The text was updated successfully, but these errors were encountered:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.