Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment Configuration #2895

Open
3 of 5 tasks
rokamdev opened this issue Sep 16, 2024 · 0 comments · May be fixed by #2900
Open
3 of 5 tasks

Augment Configuration #2895

rokamdev opened this issue Sep 16, 2024 · 0 comments · May be fixed by #2900
Labels
Priority: Medium This issue may be impactful and needs some attention. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@rokamdev
Copy link

Priority

Medium

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

Currently the augment system is classified into 3 stages: Increased Damage, Powerful Impact and Strong Impact.
Both have their percentages defined in config.lua.dist, however, some items have the same augment stage with different percentages, such as Gran Sanguine Coil.

image
image

The percentage should be inserted in the items.xml itself in the related augment, and not a "generic" value.
This adjustment makes the mechanics more precise and facilitates the insertion of items from the last update (since there are items with more than 30% bonus).

image
image

What OS are you seeing the problem on?

Linux

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rokamdev rokamdev added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Sep 16, 2024
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Sep 16, 2024
@phacUFPE phacUFPE linked a pull request Sep 18, 2024 that will close this issue
Open
11 tasks
@murilo09 murilo09 removed the Status: Pending Test This PR or Issue requires more testing label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium This issue may be impactful and needs some attention. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: new augments and update item description (amber items) opentibiabr/canary
2 participants
@murilo09 @rokamdev