From 25a1ae862937707fb42a28d037b97849a575e914 Mon Sep 17 00:00:00 2001 From: dominic reed Date: Thu, 15 Aug 2024 14:30:34 -0700 Subject: [PATCH] fix: correct h2c service appProtocol (#77) Platform's service `appProtocol` is `h2c`. According to [kubernetes docs](https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol), it should be `kubernetes.io/h2c`. HTTP Requests were being received as HTTP/1.1, rather than HTTP2 causing gRPC requests to fail. --- charts/platform/templates/headless-service.yaml | 2 +- charts/platform/templates/service.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/platform/templates/headless-service.yaml b/charts/platform/templates/headless-service.yaml index f42866b..ef6f50b 100644 --- a/charts/platform/templates/headless-service.yaml +++ b/charts/platform/templates/headless-service.yaml @@ -12,7 +12,7 @@ spec: ports: - port: {{ .Values.service.port }} targetPort: http2 - appProtocol: {{ if .Values.server.tls.enabled }}http2{{ else }}h2c{{ end }} + appProtocol: {{ if .Values.server.tls.enabled }}http2{{ else }}kubernetes.io/h2c{{ end }} protocol: TCP name: http2 selector: diff --git a/charts/platform/templates/service.yaml b/charts/platform/templates/service.yaml index c077995..0231c3b 100644 --- a/charts/platform/templates/service.yaml +++ b/charts/platform/templates/service.yaml @@ -11,7 +11,7 @@ spec: ports: - port: {{ .Values.service.port }} targetPort: http2 - appProtocol: {{ if .Values.server.tls.enabled }}http2{{ else }}h2c{{ end }} + appProtocol: {{ if .Values.server.tls.enabled }}http2{{ else }}kubernetes.io/h2c{{ end }} protocol: TCP name: http2 selector: