Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] integTest not called with test workflows during release #4805

Closed
prudhvigodithi opened this issue Oct 10, 2024 · 4 comments · Fixed by #4814
Closed

[BUG] integTest not called with test workflows during release #4805

prudhvigodithi opened this issue Oct 10, 2024 · 4 comments · Fixed by #4814
Assignees
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.18.0 Issues targeting release v2.18.0

Comments

@prudhvigodithi
Copy link
Contributor

What is the bug?

Coming from the issue opensearch-project/opensearch-metrics#68 to index the failed tests to the metrics cluster which will be useful during the release cycle to exactly find out the failed test metrics for a given RC, what was found with the security plugin is the integTest was renamed to integrationTest and security plugin uses the default integtest.sh part of the build repo. The script calls the ./gradlew integTest for running the integration tests in a repo.

With the change to integrationTest the integTest is skipped and not called, here is the sample stdout log

> Task :copyPluginPropertiesTemplate
> Task :pluginProperties
> Task :processTestResources
> Task :testClasses
> Task :integTest SKIPPED

How can one reproduce the bug?

Clone the repo and run ./gradlew integTest and see the output as integTest is skipped.

What is the expected behavior?

The expected behavior is run the integrations test using the build repo test workflows during the release. The test workflow is generic, either calls the integTest task by default or uses the script part of its own repo. Example https://github.com/opensearch-project/cross-cluster-replication/blob/main/scripts/integtest.sh.

Do you have any additional context?

  • Would recommend to continue using the integTest and not integrationTest as gradle task so that no changes needs to be made in the testing side of things during the release.
  • If want to proceed with integrationTest, the security repo need to onboard to new integtest.sh which should be part of the security repo and during the release testing this script would be called by default.
@prudhvigodithi prudhvigodithi added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 10, 2024
@prudhvigodithi
Copy link
Contributor Author

@cwperks
Copy link
Member

cwperks commented Oct 10, 2024

@prudhvigodithi, can you provide more info on the new integtest.sh? I know that a lot of repos used to contain a file called scripts/integtest.sh that has since been removed. The one in the security plugin was removed in https://github.com/opensearch-project/security/pull/3844/files. Can this file be restored and updated to reflect how integ tests are currently run in the repo?

@gaiksaya
Copy link
Member

Hi @cwperks
If the integration test task is any different than the default one used here, you can create an integtest.sh in this repo with the right task under scripts folder.

@prudhvigodithi
Copy link
Contributor Author

prudhvigodithi commented Oct 10, 2024

The integtest.sh is the script that will be used by the test workflow (that will run the integration tests across the components in Jenkins during the release window and on daily cron), so which ever gradle task is part of the integtest.sh that will be called by the workflow. Here the logic is, 1st it will check if the repo (example security) has the integtest.sh if not it will use the default (which is the current case now). So to continue use the default integtest.sh part of the build repo please make sure the Gradle task integTest (as this is defined in the default script) works.

@gaiksaya gaiksaya added the v2.18.0 Issues targeting release v2.18.0 label Oct 10, 2024
@cwperks cwperks added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.18.0 Issues targeting release v2.18.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants