Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add option to set resources for initHelper container #866

Open
guilhermeoki opened this issue Jul 25, 2024 · 1 comment · May be fixed by #754
Open

[FEATURE] Add option to set resources for initHelper container #866

guilhermeoki opened this issue Jul 25, 2024 · 1 comment · May be fixed by #754
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@guilhermeoki
Copy link
Contributor

Is your feature request related to a problem?

Yes, if a user decides to use resource quotas to enforce requests and limits, opensearch will not start because it is not possible to define resource limits to initHelper using the existing opensearch-cluster chart.

What solution would you like?

I'd like to add an option in the opensearch-cluster chart to set resources for this container.

What alternatives have you considered?

N/A

Do you have any additional context?

N/A
@guilhermeoki guilhermeoki added enhancement New feature or request untriaged Issues that have not yet been triaged labels Jul 25, 2024
@guilhermeoki guilhermeoki mentioned this issue Jul 25, 2024
Merged
4 tasks
@evheniyt evheniyt linked a pull request Jul 27, 2024 that will close this issue
Open
@dblock dblock removed the untriaged Issues that have not yet been triaged label Aug 12, 2024
@dblock
Copy link
Member

dblock commented Aug 12, 2024

[Catch All Triage - 1, 2, 3]

swoehrl-mw pushed a commit that referenced this issue Aug 13, 2024
@guilhermeoki
feat(helm): add option to set resources for initHelper (#865)
610222a 
### Description

This PR adds an option to define resources for initHelper container.

### Issues Resolved

Closes this issue
#866

### Check List
- [X] Commits are signed per the DCO using --signoff 
- [X] Unittest added for the new/changed functionality and all unit
tests are successful
- [X] Customer-visible features documented
- [X] No linter warnings (`make lint`)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Guilherme Oki <[email protected]>
@getsaurabh02 getsaurabh02 added the good first issue Good for newcomers label Aug 19, 2024
rkthtrifork pushed a commit to trifork/opensearch-k8s-operator that referenced this issue Aug 21, 2024
@guilhermeoki @rkthtrifork
feat(helm): add option to set resources for initHelper (opensearch-pr…
a11d4bc 
…oject#865)

### Description

This PR adds an option to define resources for initHelper container.

### Issues Resolved

Closes this issue
opensearch-project#866

### Check List
- [X] Commits are signed per the DCO using --signoff 
- [X] Unittest added for the new/changed functionality and all unit
tests are successful
- [X] Customer-visible features documented
- [X] No linter warnings (`make lint`)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Guilherme Oki <[email protected]>
rkthtrifork pushed a commit to trifork/opensearch-k8s-operator that referenced this issue Aug 21, 2024
@guilhermeoki @rkthtrifork
feat(helm): add option to set resources for initHelper (opensearch-pr…
9b2c23b 
…oject#865)

### Description

This PR adds an option to define resources for initHelper container.

### Issues Resolved

Closes this issue
opensearch-project#866

### Check List
- [X] Commits are signed per the DCO using --signoff 
- [X] Unittest added for the new/changed functionality and all unit
tests are successful
- [X] Customer-visible features documented
- [X] No linter warnings (`make lint`)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Guilherme Oki <[email protected]>
rkthtrifork pushed a commit to trifork/opensearch-k8s-operator that referenced this issue Aug 21, 2024
@guilhermeoki @rkthtrifork
feat(helm): add option to set resources for initHelper (opensearch-pr…
cdc52d5 
…oject#865)

### Description

This PR adds an option to define resources for initHelper container.

### Issues Resolved

Closes this issue
opensearch-project#866

### Check List
- [X] Commits are signed per the DCO using --signoff
- [X] Unittest added for the new/changed functionality and all unit
tests are successful
- [X] Customer-visible features documented
- [X] No linter warnings (`make lint`)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Guilherme Oki <[email protected]>
Signed-off-by: rkthtrifork <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Engineering Effectiveness Board
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor opensearch-cluster helm chart evheniyt/opensearch-k8s-operator
3 participants
@dblock @guilhermeoki @getsaurabh02