Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Github workflow to check lint #384

Open
tianleh opened this issue Jan 8, 2024 · 2 comments
Open

Add a Github workflow to check lint #384

tianleh opened this issue Jan 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@tianleh
Copy link
Member

tianleh commented Jan 8, 2024

Is your feature request related to a problem? Please describe

This can help surface up code style issues during PR check

Describe the solution you'd like

Add a Github workflow to check lint

Describe alternatives you've considered

No response

Additional context

No response
@tianleh tianleh added enhancement New feature or request untriaged Issues that have not yet been triaged labels Jan 8, 2024
@prudhvigodithi
Copy link
Collaborator

[Triage]
@rishabh6788 can you please take a look at this?
Thanks

@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Jan 16, 2024
@rishabh6788
Copy link
Collaborator

rishabh6788 commented Feb 15, 2024 •
edited
Loading

If I understand correctly the npm run build does run lint checks.
The command that is run is eslint --fix "bin/**/*.ts" "lib/**/*.ts" "test/**/*.ts" --ignore-pattern "**/*.d.ts" && jest.
Are you looking for something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Engineering Effectiveness Board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rishabh6788 @prudhvigodithi @tianleh