Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we setup e2e tests separately from integ tests? #2208

Open
jmazanec15 opened this issue Oct 15, 2024 · 1 comment
Open

Should we setup e2e tests separately from integ tests? #2208

jmazanec15 opened this issue Oct 15, 2024 · 1 comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@jmazanec15
Copy link
Member

Description

For this comment from @heemin32 (#2200 (review)), I was thinking I could add recall tests for this as well, but this can come with cost of adding minutes to the CI.

That being said, should we have e2e tests that we know take longer to run and could be triggered selectively by a maintainer and/or on a nightly or weekly basis? Thus, for most changes we wouldnt need to run these. What does everyone think?

I think AD has setup their repo to do this. See https://github.com/opensearch-project/anomaly-detection/blob/main/build.gradle#L321-L369.

@jmazanec15 jmazanec15 added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Oct 15, 2024
@jmazanec15
Copy link
Member Author

Discussed step: As first step, we should split up e2e tests and integ tests so that they can run in parallel for CI. In future, we can revisit selectively running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant