Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java support - JDK 17 and 21 #3192

Open
3 of 6 tasks
dlvenable opened this issue Aug 18, 2023 · 4 comments
Open
3 of 6 tasks

Update Java support - JDK 17 and 21 #3192

dlvenable opened this issue Aug 18, 2023 · 4 comments
Labels
breaking change Any change which may break existing configurations and deployments maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Milestone

Comments

@dlvenable
Copy link
Member

dlvenable commented Aug 18, 2023

Background

Data Prepper uses the Temurin releases for packages with bundled JDKs. Temurin has active LTS support for both Java 11 and 17. Java 21 is planned is a planned LTS release coming in Sep 2023.

Proposal

Update Data Prepper's supported Java versions to 21 and 17. As a breaking change, Data Prepper can stop supporting Java 11 entirely. This also means that developers can start using features which are available only in Java 17 and above.

We can also run some performance tests against Java 21 after it is released. This can help us determine if the default bundled JDK should be 21 instead of 17. Previously we found a performance gain running on Java 17 over 11 which motivated the update to bundle 17 instead.

Additionally, the Data Prepper builds can start to run against the Java 21 to ensure forward compatibility before it is the official version.

Tasks

Reference

https://adoptium.net/support/

@dlvenable dlvenable added breaking change Any change which may break existing configurations and deployments maintenance Issues to help maintain the project, such as improving builds, testing, etc. labels Aug 18, 2023
@dlvenable dlvenable added this to the v3.0 milestone Aug 18, 2023
@dlvenable dlvenable changed the title Update Java support Update Java support - JDK 17 and 21 Aug 18, 2023
@erzohrakhan
Copy link

@dlvenable I can help you with this;

@dlvenable
Copy link
Member Author

@erzohrakhan , Thank you for your help here. As you can see in the description we have a list of tasks to accomplish.

The first item will probably be to get the tests running on Java 20. I've not tried it locally, but you can try that and make any necessary changes. Once it works locally a PR to add it into the matrix below would be good.

I think the other items we will need to wait on, though Java 21 is scheduled for Sep 19. Also, it sounds like Gradle 8.3 does not yet support Java 21.

https://docs.gradle.org/current/userguide/compatibility.html

@dlvenable
Copy link
Member Author

@erzohrakhan , If you'd like to help here, the next good task may be updating to Gradle 8.4 and running against Java 21 now that it is available.

@dlvenable
Copy link
Member Author

I'd like to propose that by Data Prepper 3.0 we only support Java 21. That is, we drop support for Java 17 entirely. Java 21 is almost a year old and likely by the time we release 3.0 it will have been over a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Any change which may break existing configurations and deployments maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Projects
Status: 3.0 (not scheduled)
Development

No branches or pull requests

2 participants