Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support s3:// prefix in S3 bucket names #3143

Closed
dlvenable opened this issue Aug 11, 2023 · 2 comments · Fixed by #3156
Closed

Support s3:// prefix in S3 bucket names #3143

dlvenable opened this issue Aug 11, 2023 · 2 comments · Fixed by #3156
Labels
enhancement New feature or request
Milestone

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

The s3 source and s3 sink require the bucket name to be supplied only as a bucket name. Some users have provided the s3:// scheme in front and then hit errors.

Describe the solution you'd like

Allow the s3:// prefix and remove it from the bucket name supplied to the AWS SDK if it is supplied.

Describe alternatives you've considered (Optional)

An alternative is to have a specific validation on s3:// and tell the user very clearly that they should remove it.

@dlvenable dlvenable added untriaged enhancement New feature or request and removed untriaged labels Aug 11, 2023
@dlvenable
Copy link
Member Author

The solution here should also be included in the DLQs.

@asifsmohammed
Copy link
Collaborator

#3156

@dlvenable dlvenable added this to the v2.4 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants