diff --git a/data-prepper-plugins/opensearch/src/main/java/org/opensearch/dataprepper/plugins/sink/opensearch/index/IndexConfiguration.java b/data-prepper-plugins/opensearch/src/main/java/org/opensearch/dataprepper/plugins/sink/opensearch/index/IndexConfiguration.java index b9b2dd05d1..e23fdd4e26 100644 --- a/data-prepper-plugins/opensearch/src/main/java/org/opensearch/dataprepper/plugins/sink/opensearch/index/IndexConfiguration.java +++ b/data-prepper-plugins/opensearch/src/main/java/org/opensearch/dataprepper/plugins/sink/opensearch/index/IndexConfiguration.java @@ -129,11 +129,9 @@ private IndexConfiguration(final Builder builder) { String documentIdField = builder.documentIdField; String documentId = builder.documentId; if (indexType.equals(IndexType.TRACE_ANALYTICS_RAW)) { - documentIdField = "spanId"; - documentId = "spanId"; + documentId = "${spanId}"; } else if (indexType.equals(IndexType.TRACE_ANALYTICS_SERVICE_MAP)) { - documentIdField = "hashId"; - documentId = "hashId"; + documentId = "${hashId}"; } this.documentIdField = documentIdField; this.documentId = documentId; diff --git a/data-prepper-plugins/opensearch/src/test/java/org/opensearch/dataprepper/plugins/sink/opensearch/index/IndexConfigurationTests.java b/data-prepper-plugins/opensearch/src/test/java/org/opensearch/dataprepper/plugins/sink/opensearch/index/IndexConfigurationTests.java index 64810bf1f2..cda9476743 100644 --- a/data-prepper-plugins/opensearch/src/test/java/org/opensearch/dataprepper/plugins/sink/opensearch/index/IndexConfigurationTests.java +++ b/data-prepper-plugins/opensearch/src/test/java/org/opensearch/dataprepper/plugins/sink/opensearch/index/IndexConfigurationTests.java @@ -286,7 +286,7 @@ public void testReadIndexConfig_RawIndexType() { assertEquals(60_000L, indexConfiguration.getFlushTimeout()); assertEquals(false, indexConfiguration.isEstimateBulkSizeUsingCompression()); assertEquals(2, indexConfiguration.getMaxLocalCompressionsForEstimation()); - assertEquals("spanId", indexConfiguration.getDocumentIdField()); + assertEquals("${spanId}", indexConfiguration.getDocumentId()); } @Test @@ -312,7 +312,7 @@ public void testReadIndexConfig_ServiceMapIndexType() { assertEquals(60_000L, indexConfiguration.getFlushTimeout()); assertEquals(false, indexConfiguration.isEstimateBulkSizeUsingCompression()); assertEquals(2, indexConfiguration.getMaxLocalCompressionsForEstimation()); - assertEquals("hashId", indexConfiguration.getDocumentIdField()); + assertEquals("${hashId}", indexConfiguration.getDocumentId()); } @Test @@ -335,7 +335,7 @@ public void testReadIndexConfigCustom() { assertEquals(testFlushTimeout, indexConfiguration.getFlushTimeout()); assertEquals(true, indexConfiguration.isEstimateBulkSizeUsingCompression()); assertEquals(5, indexConfiguration.getMaxLocalCompressionsForEstimation()); - assertEquals(testIdField, indexConfiguration.getDocumentIdField()); + assertEquals(testIdField, indexConfiguration.getDocumentId()); } @Test @@ -356,7 +356,7 @@ public void testReadIndexConfig_ExplicitCustomIndexType() { assertFalse(indexConfiguration.getIndexTemplate().isEmpty()); assertEquals(testBulkSize, indexConfiguration.getBulkSize()); assertEquals(testFlushTimeout, indexConfiguration.getFlushTimeout()); - assertEquals(testIdField, indexConfiguration.getDocumentIdField()); + assertEquals(testIdField, indexConfiguration.getDocumentId()); } @Test @@ -458,7 +458,7 @@ private PluginSetting getPluginSetting(Map metadata) { } private Map initializeConfigMetaData( - String indexType, String indexAlias, String templateFilePath, Long bulkSize, Long flushTimeout, String documentIdField) { + String indexType, String indexAlias, String templateFilePath, Long bulkSize, Long flushTimeout, String documentId) { final Map metadata = new HashMap<>(); if (indexType != null) { metadata.put(IndexConfiguration.INDEX_TYPE, indexType); @@ -475,8 +475,8 @@ private Map initializeConfigMetaData( if (flushTimeout != null) { metadata.put(IndexConfiguration.FLUSH_TIMEOUT, flushTimeout); } - if (documentIdField != null) { - metadata.put(IndexConfiguration.DOCUMENT_ID_FIELD, documentIdField); + if (documentId != null) { + metadata.put(IndexConfiguration.DOCUMENT_ID, documentId); } return metadata; }