Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] makeHighContrastColor warns that it cannot make good colors for typeahead/_suggestion.scss #4628

Closed
AMoo-Miki opened this issue Jul 26, 2023 · 1 comment · Fixed by #4884
Closed

[BUG] makeHighContrastColor warns that it cannot make good colors for typeahead/_suggestion.scss #4628

AMoo-Miki opened this issue Jul 26, 2023 · 1 comment · Fixed by #4884
Assignees
@joshuarrrr
Labels
bug Something isn't working next-theme OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks OUI Issues that require migration to OUI v2.10.0

Comments

@AMoo-Miki
Copy link
Collaborator

Describe the bug

   │ warn worker stderr WARNING: High enough contrast could not be determined. Most likely your background color does not adjust for dark mode.
   │ warn worker stderr          on line 128 of node_modules/@elastic/eui/src/themes/eui-next/global_styling/functions/_colors.scss, in function `makeHighContrastColor`
   │ warn worker stderr          from line 105 of src/plugins/data/public/ui/typeahead/_suggestion.scss
   │ warn worker stderr          from line 1 of src/plugins/data/public/ui/typeahead/_index.scss
   │ warn worker stderr          from line 2 of src/plugins/data/public/ui/_index.scss
   │ warn worker stderr          from line 2 of src/plugins/data/public/index.scss
@AMoo-Miki AMoo-Miki added bug Something isn't working untriaged and removed untriaged labels Jul 26, 2023
@joshuarrrr joshuarrrr added OUI Issues that require migration to OUI OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks and removed untriaged labels Jul 31, 2023
@joshuarrrr joshuarrrr assigned BSFishy and unassigned BSFishy Aug 9, 2023
@BSFishy
Copy link
Contributor

BSFishy commented Aug 24, 2023

OpenSearch-Dashboards/src/plugins/data/public/ui/typeahead/_suggestion.scss

Line 105 in 8e1ec99

color: makeHighContrastColor($color, tintOrShade($color, 90%, 50%));

Changing 50% even to 51% fixes the issue

@joshuarrrr joshuarrrr assigned joshuarrrr and unassigned BSFishy Aug 31, 2023
@joshuarrrr joshuarrrr mentioned this issue Aug 31, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuarrrr joshuarrrr

Labels
bug Something isn't working next-theme OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks OUI Issues that require migration to OUI v2.10.0
Projects
Look & Feel
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change color fn used to calculate icon colors for search typeahead joshuarrrr/OpenSearch-Dashboards
3 participants
@joshuarrrr @AMoo-Miki @BSFishy