Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal][DeAngular][table] table visualization re-write to get rid of angular #2139

Closed
ananzh opened this issue Aug 12, 2022 · 2 comments
Closed
Assignees
Labels
de-angular de-angularize work tableVis table visualization technical debt If not paid, jeapardizes long-term success and maintainability of the repository. v2.5.0 'Issues and PRs related to version v2.5.0' visualizations Issues and PRs related to visualizations

Comments

@ananzh
Copy link
Member

ananzh commented Aug 12, 2022

Statement

Currently, table visualization is written in Angular. Angular is not supported since 12/2021 and cause high severity CVE issues. Since we decided to remove angular from current code base, table visualization needs to be refactored ore re-written in ReAct. Meanwhile, our current table visualization is old and we see new requests from users to get it updated.

In this issue, I would like to first introduce the core features of the current table visualization. Then make some high-level proposals for the new table visualization. We will leave the implementation details in another design issue.

Current Table Visualization

The table visualization is used to show data in a table format. It is bootstrapped when a table is rendered. 

create and access

create a table visualization

  • on home page, click the side bar menu and click visualize
  • on the top right of the visualizations list, click Create visualization
  • choose Data Table as the visualization type and then choose the index pattern
  • a table visualization will be rendered based on the default settings

Screen Shot 2022-08-23 at 11 12 59

access an existing table visualization

There are three ways to access the saved visualizations.

  • the visualizations list

Screen Shot 2022-08-23 at 14 19 28

  • the saved object (Stack Management --> Saved objects)

Screen Shot 2022-08-23 at 14 11 22

  • if the table vis is saved in a dashboard, you could also access it from there

Screen Shot 2022-08-23 at 14 13 01

features

sort the column (asc, desc)

Currently, there are only two ways to sort: asc and desc (see below image)

  • click the black up-pointing triangle to do asc sort
  • click the black down-pointing triangle to do desc sort

pagination

  • table has the pagination depending on how many data to show (see below image)

Screen Shot 2022-08-14 at 18 54 15

export table as csv

There are two options, Raw and Formatted
Screen Shot 2022-08-15 at 16 00 25

  • click Raw to export the data table in csv
  • click Formatted to export the data table in csv
  • There is one column missing which is chosen from options --> percentage column.

Screen Shot 2022-08-23 at 11 31 46

split table in columns and rows

  • table can be split. there are two options.

Screen Shot 2022-08-14 at 18 55 06

  • split table in Rows

Screen Shot 2022-08-14 at 18 56 18

  • split table in Columns

Screen Shot 2022-08-14 at 18 55 58

show total

  • click options --> show total. Then you will be able to select different metrics.

Screen Shot 2022-08-23 at 14 25 53

see there is a calculated total at the bottom:

Screen Shot 2022-08-23 at 13 47 27

show partial rows

  • click options --> show partial rows. This option will allow table visualization to show partial rows if there are many columns.

show metrics for every bucket/level

Screen Shot 2022-08-23 at 13 59 12

show percentage column

  • click options --> choose Percentage column and the metrics
  • the default is Don't show

Screen Shot 2022-08-23 at 13 48 01

Proposal

The purpose to create a new table visualization is to remove Angular code and upgrade our table visualization. It should be easy to use with minimum learning curve. Therefore, I would like to propose minimal changes from usage perspective:

  • use the same creation method
  • keep all the three access ways
  • keep all the current core features
  • some improvements to consider:

(a) the black up-pointing/down-pointing triangle is not clear to me
Screen Shot 2022-08-23 at 14 44 26

(b) the column width is not adjustable. when there are a lot of columns, users don't have the choice to adjust the column.
Screen Shot 2022-08-23 at 14 52 55

Providing feedback

The purpose of this proposal is to introduce our current table visualization and our thoughts to enhance the usability. We would like to collect feedback from the community. This proposal is meant to cover the high-level proposal and functionality but does not go into implementation details and architecture. Once we get feedback from the community we will publish a more detailed design doc.

For any feedback on the problem statement, the proposal, or any open questions please leave your comments on this issue. Looking forward to your input!

@ananzh ananzh added visualizations Issues and PRs related to visualizations technical debt If not paid, jeapardizes long-term success and maintainability of the repository. de-angular de-angularize work labels Aug 12, 2022
@ananzh ananzh self-assigned this Aug 12, 2022
@ananzh ananzh changed the title [DeAngular][visualization][table] remove angular from vis_type_table [DeAngular][visualization][table] table visualization re-write to get rid of angular Aug 15, 2022
@ananzh ananzh changed the title [DeAngular][visualization][table] table visualization re-write to get rid of angular [Proposal][DeAngular][table] table visualization re-write to get rid of angular Aug 23, 2022
@kavilla kavilla added the v2.4.0 'Issues and PRs related to version v2.4.0' label Sep 12, 2022
@joshuarrrr joshuarrrr added v2.5.0 'Issues and PRs related to version v2.5.0' and removed v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 22, 2022
@joshuarrrr
Copy link
Member

@ananzh I bumped this to target the 2.5.0 release.

@joshuarrrr joshuarrrr added the tableVis table visualization label Nov 22, 2022
@ananzh ananzh removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 16, 2022
@ananzh ananzh added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 11, 2023
@ananzh
Copy link
Member Author

ananzh commented Jan 11, 2023

Close it due to new table vis been merged into main.

@ananzh ananzh closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
de-angular de-angularize work tableVis table visualization technical debt If not paid, jeapardizes long-term success and maintainability of the repository. v2.5.0 'Issues and PRs related to version v2.5.0' visualizations Issues and PRs related to visualizations
Projects
Development

No branches or pull requests

3 participants