Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeAngularize] [Discover] clean doc_views component #1717

Closed
ananzh opened this issue Jun 10, 2022 · 3 comments
Closed

[DeAngularize] [Discover] clean doc_views component #1717

ananzh opened this issue Jun 10, 2022 · 3 comments
Assignees
@ananzh
Labels
de-angular de-angularize work discover for discover reinvent enhancement New feature or request v3.0.0

Comments

@ananzh
Copy link
Member

ananzh commented Jun 10, 2022 •
edited by kavilla
Loading

This is a research issue for de-angular doc_views.
There are couple of things done for doc_views:
1.deangular doc_view component
2.deangular doc view table component

What is left:
clean out registries and rest angular in doc_views
tests doc_views react component in discover

Requirements:

  • Doc views is no longer in Angular
  • Draft public documentation about component and usage

Related Issue:
This is part of our De-angular project
@ananzh ananzh added the enhancement New feature or request label Jun 10, 2022
@ananzh
Copy link
Member Author

ananzh commented Jun 10, 2022

Will research:
how to break one angular (directive+template/view+controller)
how to make react work in an angular app

@kavilla kavilla closed this as completed Jul 18, 2022
@kavilla kavilla reopened this Jul 18, 2022
@kavilla kavilla changed the title [Research] discover plugin doc_views de-angular [De-Angular] discover plugin doc_views de-angular Jul 18, 2022
@kavilla
Copy link
Member

kavilla commented Aug 1, 2022

Update: Collecting the work for executing this and breaking down.

@ananzh ananzh added de-angular de-angularize work discover for discover reinvent v3.0.0 labels Aug 2, 2022
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Aug 4, 2022
@ananzh
clean doc views component
28aaf88 
* remove the function which helps to convert angular directive to
react render function
* clean types

Issue Resolved:
opensearch-project#1717

Signed-off-by: Anan Zhuang <[email protected]>
This was referenced Aug 4, 2022
Closed
Closed
@ananzh ananzh changed the title [De-Angular] discover plugin doc_views de-angular [DeAngularize] [Discover] clean doc_views component Aug 4, 2022
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Aug 5, 2022
@ananzh
clean doc views component
7368b39 
* remove the function which helps to convert angular directive to
react render function
* clean types

Issue Resolved:
opensearch-project#1717

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh
Copy link
Member Author

ananzh commented Sep 14, 2023

This is done. doc_views is completely react in Discover 2.0. Close this issue.

@ananzh ananzh closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
de-angular de-angularize work discover for discover reinvent enhancement New feature or request v3.0.0
Projects
Dashboards DeAngularization
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kavilla @ananzh