Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize build flags between build-from-source and upstream-packaged images #109

Open
neomantra opened this issue Jun 12, 2019 · 2 comments

Comments

@neomantra
Copy link
Member

Upstream packaged images (e.g. centos via RPM) have a set of modules and build flags. See https://github.com/openresty/openresty-packaging/blob/master/rpm/SPECS/openresty.spec#L145

Harmonize these flags and make them customizable with build arguments.

For example:

ARG RESTY_LUABIND_XCFLAGS="-DLUAJIT_NUMMODE=2 -DLUAJIT_ENABLE_LUA52COMPAT"

Other things to look at are cc-opt and ld-opt. Related to #108

@neomantra
Copy link
Member Author

@agentzh At this issue comment, you point out using using a pcre tree.

If I am using --with-pcre (like here, do I need to also use those cc and ld overrides? Or does the OpenResty build system take care of that when --with-pcre is specified?

@neomantra
Copy link
Member Author

As of 1.15.8.1-3, I've implemented:

What's left is parity of the included modules....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant